OPIK-796: Add new automation rule evaluator logs endpoint #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisTkachenko
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Overall looks good, yet I'm not much in the context. Also test is missing, as discussed on daily.
Approving to unblock, but I guess would be better also to get review from @andrescrz
Comment on lines
+63
to
+77
| public static final String FIND_ALL = """ | ||
|
|
||
| SELECT * FROM automation_rule_evaluator_logs | ||
|
|
||
| WHERE workspace_id = :workspace_id | ||
|
|
||
| <if(level)> AND level = :level <endif> | ||
|
|
||
| <if(ruleId)> AND rule_id = :rule_id <endif> | ||
|
|
||
| ORDER BY timestamp DESC | ||
|
|
||
| <if(limit)> LIMIT :limit <endif><if(offset)> OFFSET :offset <endif> | ||
|
|
||
| """; |
There was a problem hiding this comment.
Usually we write queries in each line, would be better to keep the same style.
There was a problem hiding this comment.
Sure, I will remove it next.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
OPIK-796
Testing