Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OPIK-762] create an experiment dialog improvements #1136

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

awkoy
Copy link
Contributor

@awkoy awkoy commented Jan 24, 2025

Details

image

Issues

Resolves #

Testing

Documentation

@awkoy awkoy requested a review from a team as a code owner January 24, 2025 15:07
@@ -145,6 +143,11 @@ const AddExperimentDialog: React.FunctionComponent<
AddExperimentDialogProps
> = ({ open, setOpen }) => {
const workspaceName = useAppStore((state) => state.activeWorkspaceName);
const { data: user } = useUser();
Copy link
Contributor

@aadereiko aadereiko Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can use this user not in plugins. Maybe, we could discuss it with @andriidudar on Monday. But somehow, we should put it into plugins.

@awkoy awkoy requested a review from aadereiko January 27, 2025 11:31
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Nice breakdown into different plugins

@aadereiko aadereiko merged commit 6f0dfa7 into main Jan 27, 2025
2 checks passed
@aadereiko aadereiko deleted the awkoy/OPIK-762-run-exp-side-popup branch January 27, 2025 14:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants