Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolve Typing Issues on Wrapping OpenAI Client #1156

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Resolve Typing Issues on Wrapping OpenAI Client #1156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bde9b5d
added TypeVar so that output type matches input type
17jmumford Jan 27, 2025
f8735dd
updated var name to match according to mypy standards
17jmumford Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdks/python/src/opik/integrations/openai/opik_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
from typing import Optional, Union
from typing import Optional, TypeVar

import openai

from . import chat_completion_chunks_aggregator, openai_decorator

OpenAIClient = TypeVar("OpenAIClient", openai.OpenAI, openai.AsyncOpenAI)


def track_openai(
openai_client: Union[openai.OpenAI, openai.AsyncOpenAI],
openai_client: OpenAIClient,
project_name: Optional[str] = None,
) -> Union[openai.OpenAI, openai.AsyncOpenAI]:
) -> OpenAIClient:
"""Adds Opik tracking to an OpenAI client.

Tracks calls to:
Expand Down
Loading