[OPIK-905] [FE] Split find project endpoint into two endpoints: find and stats #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriidudar
force-pushed
the
andriidudar/OPIK-905-project-stats
branch
from
91ca122 to
8d7641e
Compare
aadereiko
previously approved these changes
Jan 30, 2025
| if (projectsData) { | ||
| let statisticMap: Record<string, ProjectStatistic> = {}; | ||
|
|
||
| if (projectsStatisticData && projectsStatisticData.content?.length > 0) { |
There was a problem hiding this comment.
projectsStatisticData?.content?.length > 0
There was a problem hiding this comment.
This change will lead to the next type of error:
src/hooks/useProjectWithStatisticsList.ts:47:11 - error TS18048: 'projectsStatisticData.content.length' is possibly 'undefined'. 47 if (projectsStatisticData?.content?.length > 0) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/hooks/useProjectWithStatisticsList.ts:48:24 - error TS18048: 'projectsStatisticData' is possibly 'undefined'. 48 statisticMap = projectsStatisticData.content.reduce<
Done |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
FE makes 2 requests on the Home and Projects page to retrieve projects with statistics.
Issues
Resolves #
Testing
Documentation
https://www.notion.so/cometml/Project-Endpoint-Split-18a7124010a380f8a9a7e47f4af17fcc?d=18a7124010a3807783d5001c94873d63#18a7124010a380db83fcc91fa252f529