OPIK-1010: Use better solution for case insensitive map #1271
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
approved these changes
Feb 14, 2025
| Project::name, | ||
| Function.identity(), | ||
| BinaryOperatorUtils.last(), | ||
| () -> new TreeMap<>(String.CASE_INSENSITIVE_ORDER))); |
There was a problem hiding this comment.
You could use CaseInsensitiveMap:
Probably nicer to read and without the sorting implications (performance) from TreeMap.
Anyway, this is fine too.
thiagohora
deleted the
thiagohora/OPIK-1010_use_better_solution_for_case_insensitive_map
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Using a built-in solution for the case insensitive map
Issues
OPIK-1010