OPIK-985: Regenerate OpenAi code #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
force-pushed
the
thiagohora/OPIK-985_regenerate_openapi_code
branch
from
9693152 to
a79c225
Compare
alexkuzmik
approved these changes
Feb 26, 2025
|
@ferc can I ignore this linter check? |
|
@thiagohora yes, in fact the auto-generated folder is ignored for the linter here: https://github.com/comet-ml/opik/blob/main/sdks/typescript/eslint.config.js#L7 but somehow in this CI run it doesn't take that into account Feel free to merge as is, I'll investigate why is not working as it should |
ferc
approved these changes
Feb 26, 2025
|
Okay, leaving this comment for future times, it wasn't the linter, it was the TypeScript types, the new auto-generated code has broken types = build does not work I'll try to figure it out how to solve in another PR but for future times let's double-check if it's linter (which should be excluded) or types issues FYI @aadereiko |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Regenerate OpenAi code and docs