[OPIK-1109] Add JSON support to OpenTelemetry traces ingestion #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Feb 26, 2025
| @Path("/traces") | ||
| @POST | ||
| @Consumes("application/json") | ||
| public Response receiveJsonTraces(@RequestBody String jsonPayload) { |
There was a problem hiding this comment.
I believe it would be better to create a CustomDeserializer to do all this and keep the controller simple, just receiving the Parsed Object
There was a problem hiding this comment.
The payloads can be very very different depending on the integration, we can't predict them, so I'm just repassing the parsing to the otel-protobuf library
There was a problem hiding this comment.
Now I get what you meant, it's a very neat solution, thanks!
thiagohora
previously approved these changes
Feb 26, 2025
thiagohora
approved these changes
Feb 26, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Extending Otel support for JSON payloads. Nothing too fancy, the Otel library accepts merging JSON content into a the same object you'd use for Protobuf, so the work is just making both paths converge into a single process path asap.
I'm addind as defensive programming a JSON sanitization at the beginning as the Gson library was triggering lots of exceptions from unescaped json strings.
Issues
Resolves #
Testing
Documentation