Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OPIK-42 Experiment compare for single supplied experiment #167

Merged

Conversation

andrescrz
Copy link
Collaborator

@andrescrz andrescrz commented Sep 3, 2024

Details

Handing the following case from the requirements spec:

NOTE: The behavior of how this endpoint is working can depend of a number of supplied experiments ids. In case of only 1 experiment supplied probably the product team will want to show only dataset items that was used for experiment. This should be clarified with product team.

In addition, fixed a latent bug in the normal path: join by traces not getting the last trace by update date before joining with feedback scores.

Issues

OPIK-42

Testing

  • Added integration test.

Documentation

  • Datasets & Experiments API doc.
  • Dataset Requirements doc.

@andrescrz andrescrz self-assigned this Sep 3, 2024
@andrescrz andrescrz added the enhancement New feature or request label Sep 3, 2024
@andrescrz andrescrz marked this pull request as ready for review September 3, 2024 13:04
@andrescrz andrescrz requested a review from a team as a code owner September 3, 2024 13:04
@andrescrz andrescrz merged commit 8c0b1a8 into main Sep 3, 2024
2 checks passed
@andrescrz andrescrz deleted the andrescrz/OPIK-42-experiment-compare-single-experiment branch September 3, 2024 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants