OPIK-71 Resolve dataset name in experiment endpoints #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Sep 10, 2024
|
|
||
| return dao.findById(id, workspaceId).orElseThrow(this::createNotFoundError); | ||
| @Override | ||
| public List<Dataset> findByIds(@NonNull Set<UUID> ids, @NonNull String workspaceId) { |
There was a problem hiding this comment.
Should we return only the name and ID? This probably would reduce the "overhead"
There was a problem hiding this comment.
It's an option, but I'd rather have and generic and re-usable method over something where we don't know the performance impact yet and what would be the improvement by following this approach.
We can always change this in the future.
thiagohora
approved these changes
Sep 10, 2024
andrescrz
deleted the
andrescrz/OPIK-71-resolve-dataset-name-in-experiments
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Applies to the two existing endpoints:
Datasets are stored in MySQL whereas experiments are in ClickHouse, so there's going to be a performance penalty no matter the implementation.
Implemented the dataset name retrieval in a single DB call in both cases, so there's a single MySQL query per each ClickHouse query.
Nevertheless, it should be fine in production for both endpoints:
Issues
OPIK-71
Testing
Documentation
N/A