[OPIK-354] Improve SDK robustness to connection issues #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuzmik
changed the title
alexkuzmik
changed the title
alexkuzmik
force-pushed
the
OPIK-354-investigate-network-issues-in-daily-cookbook-test-execution
branch
from
8042036 to
a1892e6
Compare
…-cookbook-test-execution
…keepalive expiry time.
alexkuzmik
force-pushed
the
OPIK-354-investigate-network-issues-in-daily-cookbook-test-execution
branch
from
967838d to
9e6e9aa
Compare
alexkuzmik
requested review from
japdubengsub
and removed request for
japdubengsub
alexkuzmik
changed the title
…-cookbook-test-execution
japdubengsub
previously approved these changes
Nov 27, 2024
| instance: Any, decorator: Callable[[Callable], Callable] | ||
| ) -> None: | ||
| attr_name: str | ||
| for attr_name in instance.__class__.__dict__.keys(): |
There was a problem hiding this comment.
This approach works fine. Though we might consider an alternative using a dir(instance) call. However, we need to verify whether it performs worse.
There was a problem hiding this comment.
You are right, dir works better since it also grabs names from parent classes, I updated the implementation.
japdubengsub
approved these changes
Nov 27, 2024
alexkuzmik
deleted the
OPIK-354-investigate-network-issues-in-daily-cookbook-test-execution
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
tenacitylib, which was added to the dependencies.tokenizersdependency for py3.8 since it's broken for py3.8Issues
Resolves the issue when the connection is expired during the request processing, request is failing and there are no more attempts to send it. SDK is more robust now to connectivity issues.
Testing
Testing was performed with the cookbooks github action workflow. It was modified to install opik locally instead of downloading it from pypi. The amount of connection/protocol errors reduced significantly and became way more rare, but it is still possible to see such failures sometimes.