Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[OPIK-474] Fix Flaky test #731

Merged
merged 2 commits into from
Nov 27, 2024
Merged

[OPIK-474] Fix Flaky test #731

merged 2 commits into from
Nov 27, 2024

Conversation

thiagohora
Copy link
Contributor

Details

  • Fixing flaky test
  • Adjusting logs

Issues

OPIK-474

@thiagohora thiagohora requested a review from a team as a code owner November 27, 2024 10:25
@thiagohora thiagohora self-assigned this Nov 27, 2024
BorisTkachenko
BorisTkachenko previously approved these changes Nov 27, 2024
Copy link
Contributor

@BorisTkachenko BorisTkachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

assertFalse(redisClient.getBucket(lock.key()).isExists().block());
StepVerifier.create(redisClient.getBucket(lock.key()).isExists())
.assertNext(data -> assertThat(data).isFalse())
.verifyComplete();
}

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new line

@thiagohora thiagohora merged commit c21c81e into main Nov 27, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-474_flaky_tests branch November 27, 2024 13:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants