[OPIK-486] Add NOT_EQUAL operator for filtering #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisTkachenko
force-pushed
the
boryst/OPIK-486-add-not-equal-operator-for-filtering
branch
from
2a2ef56 to
2e654ac
Compare
andrescrz
approved these changes
Dec 5, 2024
| @@ -12,6 +12,7 @@ public enum Operator { | |||
| STARTS_WITH("starts_with"), | |||
| ENDS_WITH("ends_with"), | |||
| EQUAL("="), | |||
| NOT_EQUAL("!="), | |||
There was a problem hiding this comment.
Just make sure FrontEnd is happy with this syntax != for the query param. From my side, it looks good.
There was a problem hiding this comment.
FE confirmed that they are good: https://comet-ml.slack.com/archives/C0768KH9MDJ/p1733391186958639
Comment on lines
+1113
to
+1115
| @ParameterizedTest | ||
| @MethodSource("equalAndNotEqualFilters") | ||
| void getByProjectName__whenFilterTotalEstimatedCostEqual_NotEqual__thenReturnSpansFiltered(Operator operator, |
There was a problem hiding this comment.
There's similar tests for equals in traces object (and maybe some other). It'd be nice to add a test for all where this applies, not only spans.
There was a problem hiding this comment.
Will add in a later PR, we also have filters in Traces and Datasets.
BorisTkachenko
deleted the
boryst/OPIK-486-add-not-equal-operator-for-filtering
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add NOT_EQUAL operator for filtering
Resolves: #551
Testing
Added corresponding integration tests