[OPIK-555] Add retries for get dataset items operation #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japdubengsub
approved these changes
Dec 9, 2024
alexkuzmik
deleted the
alexkuzmik/add-retries-for-get-dataset-items-operation
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Since fern API returned a stream object when reading dataset items, retries haven't really worked with that (we had only retries on returning a streaming object). If there was a ReadTimeout error during the chunk read - an exception was not caught and the code failed after first attempt.
This PR adds retries to the whole
get-itemsoperation inDatasetapi class.