[OPIK-582] Get experiment by name endpoint #891
Merged
+118
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
reviewed
Dec 13, 2024
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/ExperimentsResource.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/ExperimentsResource.java
Outdated
Show resolved
Hide resolved
Comment on lines
+166
to
+167
| <if(id)> AND id = :id <endif> | ||
| <if(name)> AND name = :name <endif> |
There was a problem hiding this comment.
Minor: please ensure either id or name is always provided in all code paths, otherwise it won't work as expected.
It seems to be like that in the code below.
There was a problem hiding this comment.
There are only 2 places where it's used. And each one adds corresponding clause, so it should be fine.
apps/opik-backend/src/main/java/com/comet/opik/domain/ExperimentDAO.java
Outdated
Show resolved
Hide resolved
andrescrz
approved these changes
Dec 16, 2024
BorisTkachenko
deleted the
boryst/OPIK-582-be-implement-new-endpoint-get-experiment-by-name
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Get experiment by name endpoint
Testing
Added integration tests