ABCI calls should crash/exit in all cases when the call itself reports and error #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-mena
added
backport-to-v0.37.x
jmalicevic
approved these changes
Mar 13, 2023
sergio-mena
added a commit
that referenced
this pull request
Mar 13, 2023
…ll itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly
sergio-mena
added a commit
that referenced
this pull request
Mar 13, 2023
…the call itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly
sergio-mena
added a commit
that referenced
this pull request
Mar 15, 2023
…s and error (backport #496) (#520) * ABCI calls should crash/exit in all cases when the call itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly (cherry picked from commit 2ab8598) # Conflicts: # .github/workflows/govulncheck.yml # state/execution.go * Revert "ABCI calls should crash/exit in all cases when the call itself reports and error (#496)" This reverts commit d2fae79. * [partial cherry-pick] ABCI calls should crash/exit in all cases when the call itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
added a commit
that referenced
this pull request
Mar 16, 2023
…s and error (backport #496) (#519) * ABCI calls should crash/exit in all cases when the call itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly (cherry picked from commit 2ab8598) # Conflicts: # .changelog/v0.37.0/bug-fixes/496-error-on-applyblock-should-panic.md * Revert "ABCI calls should crash/exit in all cases when the call itself reports and error (#496)" This reverts commit 825ac9e. * [cherry-picked] ABCI calls should crash/exit in all cases when the call itself reports and error (#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
roy-dydx
pushed a commit
to dydxprotocol/cometbft
that referenced
this pull request
Jul 11, 2023
…s and error (backport cometbft#496) (cometbft#519) * ABCI calls should crash/exit in all cases when the call itself reports and error (cometbft#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly (cherry picked from commit 2ab8598) # Conflicts: # .changelog/v0.37.0/bug-fixes/496-error-on-applyblock-should-panic.md * Revert "ABCI calls should crash/exit in all cases when the call itself reports and error (cometbft#496)" This reverts commit 825ac9e. * [cherry-picked] ABCI calls should crash/exit in all cases when the call itself reports and error (cometbft#496) * Review call hierarchies of ABCI methods to make sure they panic on error * Added changelog * Trying 1.20.2 explicitly --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490
Followed the call hierarchy of ABCI methods to make sure that reporting an error ultimately results in a crash/exit (also followed new methods in branch
feature/abci++vef).Found one blind spot that should be considered a bug, and should probably be backported. Hence, I'm opening this against
mainand notfeature/abci++vefPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments