Safety Test Refactor: Honda (#495)

* nidec

* bosch

* button

* more common

* packer

* more packer

* readability

* tx too

* don't need that

* delete StdTest

* don't need to duplicate this

* only nidec has interceptor

Author: adeebshihadeh

tests/safety/common.py

@@ -197,59 +197,3 @@ def test_not_allow_brake_when_moving(self):
     self.assertFalse(self.safety.get_controls_allowed())
     self._rx(self._speed_msg(0))
 
-# TODO: use PandaSafetyTest for all tests and delete this
-class StdTest:
-  @staticmethod
-  def test_relay_malfunction(test, addr, bus=0):
-    # input is a test class and the address that, if seen on specified bus, triggers
-    # the relay_malfunction protection logic: both tx_hook and fwd_hook are
-    # expected to return failure
-    test.assertFalse(test.safety.get_relay_malfunction())
-    test.safety.safety_rx_hook(make_msg(bus, addr, 8))
-    test.assertTrue(test.safety.get_relay_malfunction())
-    for a in range(1, 0x800):
-      for b in range(0, 3):
-        test.assertFalse(test.safety.safety_tx_hook(make_msg(b, a, 8)))
-        test.assertEqual(-1, test.safety.safety_fwd_hook(b, make_msg(b, a, 8)))
-
-  @staticmethod
-  def test_manually_enable_controls_allowed(test):
-    test.safety.set_controls_allowed(1)
-    test.assertTrue(test.safety.get_controls_allowed())
-    test.safety.set_controls_allowed(0)
-    test.assertFalse(test.safety.get_controls_allowed())
-
-  @staticmethod
-  def test_spam_can_buses(test, TX_MSGS):
-    for addr in range(1, 0x800):
-      for bus in range(0, 4):
-        if all(addr != m[0] or bus != m[1] for m in TX_MSGS):
-          test.assertFalse(test.safety.safety_tx_hook(make_msg(bus, addr, 8)))
-
-  @staticmethod
-  def test_allow_brake_at_zero_speed(test):
-    # Brake was already pressed
-    test.safety.safety_rx_hook(test._speed_msg(0))
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.safety.set_controls_allowed(1)
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.assertTrue(test.safety.get_controls_allowed())
-    test.safety.safety_rx_hook(test._brake_msg(0))
-    test.assertTrue(test.safety.get_controls_allowed())
-    # rising edge of brake should disengage
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.assertFalse(test.safety.get_controls_allowed())
-    test.safety.safety_rx_hook(test._brake_msg(0))  # reset no brakes
-
-  @staticmethod
-  def test_not_allow_brake_when_moving(test, standstill_threshold):
-    # Brake was already pressed
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.safety.set_controls_allowed(1)
-    test.safety.safety_rx_hook(test._speed_msg(standstill_threshold))
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.assertTrue(test.safety.get_controls_allowed())
-    test.safety.safety_rx_hook(test._speed_msg(standstill_threshold + 1))
-    test.safety.safety_rx_hook(test._brake_msg(1))
-    test.assertFalse(test.safety.get_controls_allowed())
-    test.safety.safety_rx_hook(test._speed_msg(0))