Skip to content

Commit f7bd2c2

Browse files
authored
Misra 10.4: fix last 2 violations (#242)
1 parent 9be5fde commit f7bd2c2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

board/drivers/gmlan_alt.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ int append_crc(char *in, int in_len) {
4444
unsigned int crc = 0;
4545
for (int i = 0; i < in_len; i++) {
4646
crc <<= 1;
47-
if ((in[i] ^ ((crc >> 15) & 1U)) != 0U) {
47+
if (((unsigned int)(in[i]) ^ ((crc >> 15) & 1U)) != 0U) {
4848
crc = crc ^ 0x4599U;
4949
}
5050
crc &= 0x7fffU;
@@ -68,8 +68,8 @@ int append_bits(char *in, int in_len, char *app, int app_len) {
6868

6969
int append_int(char *in, int in_len, int val, int val_len) {
7070
int in_len_copy = in_len;
71-
for (int i = val_len-1; i >= 0; i--) {
72-
in[in_len_copy] = ((unsigned int)(val) & (1U << (unsigned int)(i))) != 0;
71+
for (int i = val_len - 1; i >= 0; i--) {
72+
in[in_len_copy] = ((unsigned int)(val) & (1U << (unsigned int)(i))) != 0U;
7373
in_len_copy++;
7474
}
7575
return in_len_copy;

0 commit comments

Comments
 (0)