Add logging around generating diff comment #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvarts
force-pushed
the
sd-874-add-log-for-empty-diff-instead-of-no-diff
branch
from
3923834 to
62fb2db
Compare
yzdann
approved these changes
Dec 12, 2024
hnnsgstfssn
deleted the
sd-874-add-log-for-empty-diff-instead-of-no-diff
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change adds a log statement to provide more detailed information about the components being processed for the ArgoCD Diff Comment. This is to help with debugging this issue: Empty diff instead of No Diff. My suspicion is that the diffElements is empty, which results in an empty diff comment.
Type of Change
Checklist