Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Warn user when changing ArgoCD apps that have sync/health issues #65

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Warn user when changing ArgoCD apps that have sync/health issues #65

merged 2 commits into from
Jan 24, 2025

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Jan 22, 2025 •
edited
Loading

Description

image

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@Oded-B Oded-B requested a review from a team as a code owner January 22, 2025 15:57
@sunchill06
Copy link
Contributor

Hi @Oded-B , is this related to https://commercetools.atlassian.net/browse/SD-939 ?

@Oded-B Oded-B changed the title Warn user when changing ArgoCD apps that are unhealthy/OutOfSync or auto-sync is off Warn user when changing ArgoCD apps that have sync/health issues Jan 24, 2025
@Oded-B
Copy link
Collaborator Author

Oded-B commented Jan 24, 2025

Hi @Oded-B , is this related to https://commercetools.atlassian.net/browse/SD-939 ?

Yes

@Oded-B Oded-B merged commit f3785d2 into main Jan 24, 2025
5 checks passed
@Oded-B Oded-B deleted the warn_on_app_state branch January 24, 2025 09:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hnnsgstfssn hnnsgstfssn hnnsgstfssn approved these changes

@Freyert Freyert Awaiting requested review from Freyert Freyert is a code owner automatically assigned from commercetools/special-delivery

@ashvarts ashvarts Awaiting requested review from ashvarts ashvarts is a code owner automatically assigned from commercetools/special-delivery

@yzdann yzdann Awaiting requested review from yzdann yzdann is a code owner automatically assigned from commercetools/special-delivery

@sunchill06 sunchill06 Awaiting requested review from sunchill06 sunchill06 is a code owner automatically assigned from commercetools/special-delivery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oded-B @sunchill06 @hnnsgstfssn