Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

travis build --test --pedantic fails for warning in dependency #1292

Closed
alanz opened this issue Nov 5, 2015 · 7 comments
Closed

travis build --test --pedantic fails for warning in dependency #1292

alanz opened this issue Nov 5, 2015 · 7 comments

Comments

@alanz
Copy link
Contributor

alanz commented Nov 5, 2015

See https://travis-ci.org/haskell/haskell-ide-engine/builds/89528688

The build is initiated with

./travis_long stack +RTS -N2 -RTS build --test --haddock --pedantic

One of the dependencies of one of the sub-projects (HaRe) has a warning in it

    [ 6 of 25] Compiling Language.Haskell.Refact.Utils.Monad ( src/Language/Haskell/Refact/Utils/Monad.hs, .stack-work/dist/x86_64-linux/Cabal-1.22.4.0/build/Language/Haskell/Refact/Utils/Monad.o )
    src/Language/Haskell/Refact/Utils/Monad.hs:211:10: Warning:
        No explicit implementation for
          ‘GM.gmoAsk’
        In the instance declaration for ‘GM.GmOut (StateT RefactState IO)’

The build then terminates with

The command "./travis_long stack +RTS -N2 -RTS build --test --haddock --pedantic" exited with 1.

Is this expected behaviour?

stack installed via

travis_retry curl -L https://github.com/commercialhaskell/stack/releases/download/v0.1.4.0/stack-0.1.4.0-x86_64-linux.tar.gz | tar xz -C ~/.local/bin
@mgsloan
Copy link
Contributor

mgsloan commented Nov 6, 2015

Good point, I agree that --pedantic should only apply to local packages. This is related to #849 / #1265

@mgsloan mgsloan added this to the P2: Should milestone Nov 6, 2015
@alanz
Copy link
Contributor Author

alanz commented Nov 6, 2015

I updated stack to

Version 0.1.6.0, Git revision e22271f5ce9afa2cb5be3bad9cafa392c623f85c (2313 commits) x86_64

by using

travis_retry curl -L https://www.stackage.org/stack/linux-x86_64 | tar xz --wildcards --strip-components=1 -C ~/.local/bin '*/stack'

The problem is no longer there. So perhaps it was misdiagnosed.

@alanz
Copy link
Contributor Author

alanz commented Nov 6, 2015

Nope, spoke to soon, the travis cache meant HaRe was not rebuilt.

See https://travis-ci.org/haskell/haskell-ide-engine/builds/89597777 where it was merged to master with a new cache and shows the same problem.

Not sure if it is --haddock or --pedantic that does it though.

@alanz
Copy link
Contributor Author

alanz commented Nov 6, 2015

I just ran a build on travis which failed doing

stack +RTS -N2 -RTS build --haddock

This is after successfully doing

./travis_long stack +RTS -N2 -RTS build --only-snapshot --pedantic

Does --haddock re-install all the dependencies? Which seems to be the case in this build

alanz added a commit to haskell/haskell-ide-engine that referenced this issue Nov 6, 2015
@borsboom
Copy link
Contributor

borsboom commented Nov 6, 2015

--haddock does rebuild dependencies that don't already have haddocks.

@borsboom
Copy link
Contributor

@alanz: the --haddock issue sounds like #1317, and the --pedantic will be covered by #1265. I'm thinking we can close this as duplicate, but let me know if those issues don't seem to cover it.

@alanz
Copy link
Contributor Author

alanz commented Nov 17, 2015

Sounds fine.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants