Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add configure-options settings (fixes #1438) #4750

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

snoyberg
Copy link
Contributor

Addresses #1438

Two points for discussion on this PR:

  • Should we also be adding configure-options to Pantry snapshots, like we have support for ghc-options?
  • Should we attempt to fold the ghc-options values into this field? I think not, since some commands use ghc-options but don't use configure-options (like ghci)

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg snoyberg requested a review from qrilka April 16, 2019 13:46
@qrilka
Copy link
Contributor

qrilka commented Apr 18, 2019

Regarding that these options are quite similar to ghc-options it looks to make sense to have them supported in snapshots as well. The other question is that they probably won't get used much.
As for merging ghc-options into this field I agree that probably we should keep them separate and it's user's responsibility to check for any conflicts.
The PR looks good to me but I guess it's better to add support to snapshots as a part of it?

@snoyberg
Copy link
Contributor Author

@qrilka and I followed up in a private chat about this, and decided that we don't want to require tools that process snapshot files to support arbitrary configure options right now. So we're going to leave this PR as-is.

@snoyberg snoyberg merged commit 5a03401 into master Apr 18, 2019
@snoyberg snoyberg deleted the 1438-configure-options branch April 18, 2019 14:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants