Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --no-tests parameter to stack test #517

Merged
merged 1 commit into from
Jul 7, 2015

Conversation

JulianBirch
Copy link
Contributor

New version of the PR addressing #430. Piggybacks on the toRun concept introduced in the last week now. No large scale splitting out of existing code.

@snoyberg
Copy link
Contributor

snoyberg commented Jul 6, 2015

This seems fine overall, but I think the naming is confusing. Perhaps --no-run-tests?

@JulianBirch
Copy link
Contributor Author

Seems sensible. Will try to update it tonight.

On Monday, July 6, 2015, Michael Snoyman notifications@github.com wrote:

This seems fine overall, but I think the naming is confusing. Perhaps
--no-run-tests?


Reply to this email directly or view it on GitHub
#517 (comment)
.

Sent from an iPhone, please excuse brevity and typos.

@JulianBirch
Copy link
Contributor Author

Here's a revised (and re-rebased) version.

snoyberg added a commit that referenced this pull request Jul 7, 2015
Add --no-tests parameter to stack test
@snoyberg snoyberg merged commit c2753e8 into commercialhaskell:master Jul 7, 2015
@snoyberg
Copy link
Contributor

snoyberg commented Jul 7, 2015

Thanks!

snoyberg added a commit that referenced this pull request Jul 7, 2015
@JulianBirch
Copy link
Contributor Author

Thanks for all your help!

On Tuesday, July 7, 2015, Michael Snoyman notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#517 (comment)
.

Sent from an iPhone, please excuse brevity and typos.

dysinger added a commit that referenced this pull request Jul 8, 2015
* master:
  #279 Add retries (default 3) to verifiedDownload
  Upper limit on number of flag combinations to test #543
  Flip order of build and test/bench opts parser
  Move `boptsCoverage` and `boptsNoTests` to `TestOpts`
  Replace `boptsAdditionalArgs` with fields in `FinalAction`
  Add benchmark and test options to FinalAction
  Implement `stack bench --benchmark-arguments`
  Fix #537
  Targets outside of root dir don't build (fixes #366)
  Add changelog for #517
  Add --no-run-tests parameter to stack test.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants