Refactoring toward cabal #6614
Merged
Refactoring toward cabal #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theobat
force-pushed
the
refactoring-toward-cabal
branch
2 times, most recently
from
fe84c66
to
528881b
Compare
mpilgrem
reviewed
Jun 22, 2024
|
#6615 is now merged, so this could be re-based on |
mpilgrem
force-pushed
the
refactoring-toward-cabal
branch
from
528881b
to
cc2a57f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step for #6593, the changes in DumpPackage are not done here, because a first move was to bring some types closer to cabal, step by step.
This includes 2 major changes :
The second change is also a refactoring towards better type safety and documentation. It should also increase overall stack's speed by two aspects : better memory layout with ShortText, and less translation work from cabal.
Indicative integration tests speed:
1185 ubuntu
951 macos
1491 windows
So this corroborates a small speedup (compared to baseline #6615)