-
Notifications
You must be signed in to change notification settings - Fork 77
What should the links do? #10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I don't think browsers have API for this. The “links” just roughly give you an idea of where source file is. |
We could look into changing the links so that they open an editor with the file at that specific line, if the URL scheme is registered. Better Errors for example does this for Rack Apps. https://github.com/dhoulb/subl for example allows to set up a |
As @mxlje said, the idea was to change this at some point in the future to open the line of code somewhere. My original intent was to open them in the chrome dev tools, but maybe we can come up with a better idea. |
I think opening in the editor would be awesome. FYI, starting with |
FYI Jetbrains IDEs also support URL handlers with little configuration. Jetbrains and Sublime allow to specify line numbers. Maybe we could also pass them down to the |
If filenames are absolute the generated links can be opened in an editor if the `editorScheme` property is set. If `react-transform-catch-errors` passes in a `filename` this is used for the top function if the stack trace filename isn't absolute Closes: commissure#10
I notice errors are links e.g.
webpack:///./src/components/Pane.js?:186:56
Clicking the link does nothing. How do I make the link do something interesting like display that line in context in editor or browser.
The text was updated successfully, but these errors were encountered: