-
Notifications
You must be signed in to change notification settings - Fork 43
[FEAT]: 🎉 Add Support for GPG Signing #50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
See One of the two will have to be performed:
Currently, using import-gpg and copy-pasting and running I found import-gpg uses TypeScript, which I am only vaguely familiar with at this point, so I'm not able to convert it into a shell script. |
fix: check_consistency beign ignored * feat(action.yml): add `gpg` inputs Add input for GPG key and passphrase and whether or not to sign. * feat(entrypoing.sh): add `gpg` sign Add `-s` to `bump` command if `gpg_sign` is 'true'. * fix(entrypoint.sh): set git config Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`. * fix(gpg): add `signingkey` Git requires `signingkey` to sign commits and tags. feat(debug): add option for debug output * fix(signingkey): specify UID Git takes the UID for the signing key, not the key itself. * fix(entrypoint.sh): add `gpg.program` Add `gpg.program` to Git config. * feat(entrypoint.sh): write `gpg` script Use bash script to configure the GPG agent, import keys, set the passphrase, and configure Git. * fix(entrypoint.sh): replace `systemctl` Use `service` as `systemctl` is not on GitHub Actions runners. * fix(entrypoint.sh): remove `sudo` * Revert "fix(entrypoint.sh): replace `systemctl`" This reverts commit 2cf68aa. * Revert "feat(entrypoint.sh): write `gpg` script" This reverts commit a1c8571. * Revert "fix(entrypoint.sh): add `gpg.program`" This reverts commit 94d316f. * fix(entrypoint.sh): remove signing commits Only sign tags. It may be that `commitizen` only supports signing tags. See: commitizen-tools/commitizen#616 * fix(entrypoint.sh): remove signing configs Remove `tag.gpgsign` and `commit.gpgsign` from local Git config. * fix(entrypoint.sh): remove `--gpg-sign` See if Git will sign for us instead of through `cz`. * fix(entrypoint.sh): add `commit.gpgsign` Remove specifying `gpg.program` and add `commit.gpgsign` back. * fix(entrypoint.sh): add `gpg-sign` back Add `--gpg-sign` back to `commitizen`. * fix(entrypoint.sh): move `--gpg-sign` after bump Switch `--gpg-sign` applies to `bump` subcommand. * fix(entrypoint.sh): move `--debug` Move `--debug` switch to after `bump` command. * Revert "fix(entrypoint.sh): move `--debug`" This reverts commit e543aff. * fix(entrypoint.sh): add `commit.gpgsign` * ci(test): add `gpg -K` to stdout * ci(test): more printouts * ci(test): even more printouts * ci(test): print which `gpg` is running * ci(test): let `import-gpg` setup `gpg` * ci(test): print `gpg --version` * feat(ci): run in docker container * Revert "feat(ci): run in docker container" This reverts commit 3b2cae5. Closes: #50 Closes: #53 Co-authored-by: Hendry, Adam <adam.hendry@metronic.com>
fix: check_consistency beign ignored Add input for GPG key and passphrase and whether or not to sign. Add `-s` to `bump` command if `gpg_sign` is 'true'. Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`. Git requires `signingkey` to sign commits and tags. feat(debug): add option for debug output Git takes the UID for the signing key, not the key itself. Add `gpg.program` to Git config. Use bash script to configure the GPG agent, import keys, set the passphrase, and configure Git. Use `service` as `systemctl` is not on GitHub Actions runners. This reverts commit 2cf68aa. This reverts commit a1c8571. This reverts commit 94d316f. Only sign tags. It may be that `commitizen` only supports signing tags. See: commitizen-tools/commitizen#616 Remove `tag.gpgsign` and `commit.gpgsign` from local Git config. See if Git will sign for us instead of through `cz`. Remove specifying `gpg.program` and add `commit.gpgsign` back. Add `--gpg-sign` back to `commitizen`. Switch `--gpg-sign` applies to `bump` subcommand. Move `--debug` switch to after `bump` command. This reverts commit e543aff. This reverts commit 3b2cae5. Closes: #50 Closes: #53 Co-authored-by: Hendry, Adam <adam.hendry@metronic.com>
fix: check_consistency flag being ignored Add input for GPG key and passphrase and whether or not to sign. Add `-s` to `bump` command if `gpg_sign` is 'true'. Set `gpg.program`, `commit.gpgsign`, and `tag.gpgsign`. Git requires `signingkey` to sign commits and tags. feat(debug): add option for debug output Git takes the UID for the signing key, not the key itself. Add `gpg.program` to Git config. Use bash script to configure the GPG agent, import keys, set the passphrase, and configure Git. Use `service` as `systemctl` is not on GitHub Actions runners. This reverts commit 2cf68aa. This reverts commit a1c8571. This reverts commit 94d316f. Only sign tags. It may be that `commitizen` only supports signing tags. See: commitizen-tools/commitizen#616 Remove `tag.gpgsign` and `commit.gpgsign` from local Git config. See if Git will sign for us instead of through `cz`. Remove specifying `gpg.program` and add `commit.gpgsign` back. Add `--gpg-sign` back to `commitizen`. Switch `--gpg-sign` applies to `bump` subcommand. Move `--debug` switch to after `bump` command. This reverts commit e543aff. This reverts commit 3b2cae5. Closes: #50 Closes: #53 Co-authored-by: Hendry, Adam <adam.hendry@metronic.com>
Hey! I had a question about the workarounds. I have a workflow pretty similar to #72 using crazy-max/ghaction-import-gpg@v6. I'm getting an error where there isn't a secret key found by GPG. I used the
Could you explain the workaround? |
Currently, this action doesn't support
gpg
signing commits and tags. This could be added simply by modifying theentrypoint.sh
script to accept agpg
passphrase and key that have been added asSECRETS
to the repo.The text was updated successfully, but these errors were encountered: