Skip to content

build(deps-dev): bump mypy to 1.16.0 #1480

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

gbaian10
Copy link
Contributor

Description

Resolves #1476

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
    • Check if there are any broken links in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels May 31, 2025
@Lee-W
Copy link
Member

Lee-W commented May 31, 2025

we'll need to fix the style check failure due to this upgrade before merging it

@Lee-W Lee-W added pr-status: wait-for-modification and removed pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check labels May 31, 2025
@Lee-W Lee-W self-requested a review May 31, 2025 04:39
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (c0220cd) to head (952c699).
Report is 2 commits behind head on refactors.

Additional details and impacted files
@@            Coverage Diff             @@
##           refactors    #1480   +/-   ##
==========================================
  Coverage      97.82%   97.82%           
==========================================
  Files             57       57           
  Lines           2618     2618           
==========================================
  Hits            2561     2561           
  Misses            57       57           
Flag Coverage Δ
unittests 97.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaian10
Copy link
Contributor Author

we'll need to fix the style check failure due to this upgrade before merging it

Fixed

@Lee-W Lee-W merged commit 5c9932d into commitizen-tools:refactors May 31, 2025
18 checks passed
@gbaian10 gbaian10 deleted the upgrade-mypy branch May 31, 2025 07:10
@gbaian10 gbaian10 mentioned this pull request May 31, 2025
This was referenced Jun 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants