Skip to content

Allow overrides using reqs from CWL v1.1+ #1755

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Oct 24, 2022

Fixes #1754

  • tests overrides
    • v1.1 document with cwltool:NetworkAccess
    • v1.1 document with normal NetworkAccess
    • v1.1 document with cwltool:Secrets

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1755 (bcfcbd0) into main (abd24e0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   82.37%   82.38%   +0.01%     
==========================================
  Files          47       47              
  Lines        8174     8174              
  Branches     2228     2228              
==========================================
+ Hits         6733     6734       +1     
  Misses        947      947              
+ Partials      494      493       -1     
Impacted Files Coverage Δ
cwltool/load_tool.py 86.66% <100.00%> (ø)
cwltool/job.py 81.06% <0.00%> (-0.40%) ⬇️
cwltool/workflow_job.py 86.96% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c marked this pull request as ready for review October 24, 2022 15:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkAccess requirement not applicable in cwltool:overrides
1 participant