-
-
Notifications
You must be signed in to change notification settings - Fork 232
Improve environmental variable caching #2101
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 84.75% 84.82% +0.07%
==========================================
Files 46 46
Lines 8368 8381 +13
Branches 1962 1966 +4
==========================================
+ Hits 7092 7109 +17
+ Misses 808 804 -4
Partials 468 468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @stxue1 ; this will need some extra tests added to confirm your fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra tests! I see that they motivated some code changes :-)
37aa2ed
to
0a2475c
Compare
Example: `tox -e py311-unit -- --lf --pdb`
Especially with regards to overrides and `--preserve{-entire,}-environement` Added more tests for environment variable caching Co-authored-by: Michael R. Crusoe <mrc@commonwl.org>
PR to support environmental variable caching as mentioned here: DataBiosphere/toil#5187 (comment)
The structure of the preserve_environment code is roughly copied from a related function:
cwltool/cwltool/job.py
Lines 486 to 497 in 1b56338