Step name callback #2109
Merged
Step name callback #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
+ Coverage 84.69% 84.78% +0.09%
==========================================
Files 46 46
Lines 8364 8368 +4
Branches 1961 1962 +1
==========================================
+ Hits 7084 7095 +11
+ Misses 809 805 -4
+ Partials 471 468 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
|
@mr-c did you see this? |
mr-c
reviewed
May 19, 2025
Comment on lines
+65
to
+66
| vfinputs = {shortname(k): v for k, v in joborder.items()} | ||
| runtimeContext.name = runtimeContext.workflow_job_step_name_callback(self, vfinputs) |
There was a problem hiding this comment.
I don't understand. There is a test test_workflow_job_step_name_callback and codecov says "All modified and coverable lines are covered by tests"
There was a problem hiding this comment.
There was a problem hiding this comment.
codecov was out of date, I hit "refresh" and now it says 100% coverage?
There was a problem hiding this comment.
Can you squash or otherwise force-push this branch?
mr-c
approved these changes
May 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a callback hook to runtime context to provide custom logic for naming individual instances of steps (especially including scatter steps). This does not include a cwltool extension, as such a pull request (#1477) was made in 2021 and rejected, so it only adds the hook so that others can provide the desired functionality.