aspect ratio updates after layout completion

commons-app · Apr 7, 2020 · 47c1894 · 47c1894
1 parent 1dc0dec
commit 47c1894
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
@@ -227,7 +227,13 @@ public void onResume() {
                     .setVisibility(View.GONE);
         }
         media = detailProvider.getMediaAtPosition(index);
-        displayMediaDetails();
+
+        scrollView.post(new Runnable() {
+            @Override
+            public void run() {
+                displayMediaDetails();
+            }
+        });
     }
 
     private void displayMediaDetails() {
@@ -246,21 +252,14 @@ private void displayMediaDetails() {
 
     private void updateAspectRatio(ImageInfo imageInfo) {
         if (imageInfo != null) {
-            int screenWidth = getScreenWidth(getContext());
+            int screenWidth = scrollView.getWidth();
             int finalHeight = (screenWidth*imageInfo.getHeight()) / imageInfo.getWidth();
             ViewGroup.LayoutParams params = image.getLayoutParams();
             params.height = finalHeight;
             image.setLayoutParams(params);
         }
     }
 
-    private int getScreenWidth(Context context) {
-        DisplayMetrics dm = new DisplayMetrics();
-        WindowManager windowManager = (WindowManager) context.getSystemService(WINDOW_SERVICE);
-        windowManager.getDefaultDisplay().getMetrics(dm);
-        return dm.widthPixels;
-    }
-
     private final ControllerListener aspectRatioListener = new BaseControllerListener<ImageInfo>() {
         @Override
         public void onIntermediateImageSet(String id, @Nullable ImageInfo imageInfo) {