-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use variant-dependent variable to make URLs for vanishing #6117
Conversation
Actually, according to https://phabricator.wikimedia.org/T380527 it might be better to use Meta until the logging issue is resolved. EDIT: Local endpoints continue to be available, too. So both Meta-Wiki and Commons endpoints would be fine. Should we still use the Meta-Wiki URLs? That can be accommodated, if needed. |
Is there a particular reason you suggest to still use Meta-wiki? Do you say that because the Wikipedia app uses it? |
The fact that T380527 (linked above) is not resolved might be another (small) reason - I think by using Meta-Wiki the lock as a result of vanishing will be logged on Meta-Wiki, too. Apparently the global community likes that, although I would expect local communities don't mind either way. Realistically I expect few people look at those automated locks anyway. |
Ok. It's fine to use the Meta-wiki for now, I suppose. But how would it work for the beta cluster? Should just use the local wiki there in case beta does not have a corresponding meta wiki? |
There is a Meta wiki in the beta cluster. The URL is meta.wikimedia.beta.wmflabs.org instead of commons.wikimedia.beta.wmflabs.org. Everything seems to work like the production wikis (except that vanishing requests seem to be perpetually pending). |
I added a variable for the meta wiki URL. As for the tests, I did the same.
I added a comment that we (presumably) can use the local URL after T380527 is resolved, too. |
Description (required)
This is a follow up to #6098.
I made it work for the beta flavor, and updated the URLs for vanishing.
Here are rationales for the change:
I believe the old contact URL only worked for meta.wikimedia.org (which is still the case for other types of Special:Contact/xyz). It is not the case for the new URL, apparently.
Tests performed (required)
After this testing, my beta account is pending approval for the vanishing. It seems that less people are monitoring Beta Commons, if someone is doing it at all. If it won't get actually renamed, I think getting it in the pending stage is enough for testing the beta flavor.
I stopped before proceeding to request vanishing at this time for production.