Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use variant-dependent variable to make URLs for vanishing #6117

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

whym
Copy link
Collaborator

@whym whym commented Jan 11, 2025

Description (required)

This is a follow up to #6098.

I made it work for the beta flavor, and updated the URLs for vanishing.

Here are rationales for the change:

Tests performed (required)

  • Tested betaDebug on emulator (API 35) - the vanishing request page on Beta Commons loaded.
  • Tested prodDebug on emulator (API 35) - the vanishing request page on Commons loaded.

After this testing, my beta account is pending approval for the vanishing. It seems that less people are monitoring Beta Commons, if someone is doing it at all. If it won't get actually renamed, I think getting it in the pending stage is enough for testing the beta flavor.

I stopped before proceeding to request vanishing at this time for production.

@whym whym changed the title Use HOME_URL for to make URLs for vanishing Use HOME_URL to make URLs for vanishing Jan 11, 2025
@whym
Copy link
Collaborator Author

whym commented Jan 12, 2025

Actually, according to https://phabricator.wikimedia.org/T380527 it might be better to use Meta until the logging issue is resolved.

EDIT: Local endpoints continue to be available, too. So both Meta-Wiki and Commons endpoints would be fine.

Should we still use the Meta-Wiki URLs? That can be accommodated, if needed.

@whym whym marked this pull request as draft January 12, 2025 08:23
@whym whym marked this pull request as ready for review January 14, 2025 03:21
@sivaraam
Copy link
Member

Should we still use the Meta-Wiki URLs? That can be accommodated, if needed.

Is there a particular reason you suggest to still use Meta-wiki? Do you say that because the Wikipedia app uses it?

@whym
Copy link
Collaborator Author

whym commented Jan 15, 2025

Do you say that because the Wikipedia app uses it?

The fact that T380527 (linked above) is not resolved might be another (small) reason - I think by using Meta-Wiki the lock as a result of vanishing will be logged on Meta-Wiki, too. Apparently the global community likes that, although I would expect local communities don't mind either way. Realistically I expect few people look at those automated locks anyway.

@sivaraam
Copy link
Member

Ok. It's fine to use the Meta-wiki for now, I suppose. But how would it work for the beta cluster? Should just use the local wiki there in case beta does not have a corresponding meta wiki?

@whym
Copy link
Collaborator Author

whym commented Jan 16, 2025

There is a Meta wiki in the beta cluster. The URL is meta.wikimedia.beta.wmflabs.org instead of commons.wikimedia.beta.wmflabs.org. Everything seems to work like the production wikis (except that vanishing requests seem to be perpetually pending).

@whym whym changed the title Use HOME_URL to make URLs for vanishing Use variant-dependent variable to make URLs for vanishing Jan 16, 2025
@whym
Copy link
Collaborator Author

whym commented Jan 16, 2025

I added a variable for the meta wiki URL.

As for the tests, I did the same.

Tested betaDebug on emulator (API 35) - the vanishing request page on Beta Commons loaded.
Tested prodDebug on emulator (API 35) - the vanishing request page on Commons loaded.

I added a comment that we (presumably) can use the local URL after T380527 is resolved, too.

@nicolas-raoul nicolas-raoul merged commit 35a2fe8 into commons-app:main Jan 17, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants