Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolve error preventing nearby uploads from linking to Wikidata entities #6188

Conversation

Sujal-Gupta-SG
Copy link
Contributor

Fixes #6123

@Sujal-Gupta-SG
Copy link
Contributor Author

Sujal-Gupta-SG commented Feb 15, 2025

@nicolas-raoul In this branch, I have only made the necessary changes to support nearby uploading contributions and link them to nearby Wikidata entities.

I have also checked and tested this branch, and it is working great.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Releasing this would make the remaining issue (user's Default description language setting not respected) very hard for testers to get clues.
And the several different changes would make it less obvious to see what really fixed the linking issue.

Also, the arguments order and SuppressLint are a big distraction here, they must be made in a different pull request.

Please make it exactly like #6156 (review) thanks! :-) I can also do it if you prefer for any reason.

@nicolas-raoul
Copy link
Member

Alternatively, you can perform a git bisect to find out what commit triggered the linking issue, and either revert it or fix it.

(I performed a git bisect before but was using a picture far from the item, so it fails failing for each commit)

@Sujal-Gupta-SG
Copy link
Contributor Author

Sujal-Gupta-SG commented Feb 17, 2025

I've made the changes as per your request. I’ve run the code, and it works correctly, but there’s a "bug" that appears before selecting the correct language.

The only remaining issue seems to be related to the language setting. If you'd like, I can raise a separate pull request for the SuppressLint and Locale.getDefault().language changes. Please let me know if that approach works, or if you'd prefer a different solution.

@nicolas-raoul nicolas-raoul merged commit 40241b4 into commons-app:main Feb 17, 2025
1 check passed
@Sujal-Gupta-SG Sujal-Gupta-SG deleted the New-Nearby-upload-not-being-linked-from-Wikidata branch February 17, 2025 14:03
nicolas-raoul added a commit that referenced this pull request Feb 26, 2025
…ntroduces issue #6191

* Make neccesary changes

* Make neccesary changes

* spacing

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nearby upload not being linked from Wikidata
2 participants