Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Visual dicom browser enh #1218

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Visual dicom browser enh #1218

merged 1 commit into from
Sep 10, 2024

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Sep 9, 2024

No description provided.

@Punzo Punzo mentioned this pull request Sep 9, 2024
Merged
@Punzo Punzo force-pushed the visualDICOMBrowserENH branch from b204aa2 to 47db447 Compare September 9, 2024 18:14
@Punzo Punzo marked this pull request as draft September 9, 2024 18:39
@Punzo Punzo force-pushed the visualDICOMBrowserENH branch from 47db447 to 06bd7dc Compare September 9, 2024 19:01
@Punzo Punzo marked this pull request as ready for review September 9, 2024 19:01
@Punzo
Copy link
Contributor Author

Punzo commented Sep 9, 2024

@lassoan new integrative PR from #1217

@Punzo Punzo mentioned this pull request Sep 9, 2024
Merged
@Punzo Punzo force-pushed the visualDICOMBrowserENH branch from 06bd7dc to e4e1891 Compare September 9, 2024 20:41
lassoan
lassoan reviewed Sep 9, 2024
View reviewed changes
Libs/DICOM/Core/ctkDICOMDatabase_p.h Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Core/ctkDICOMDatabase.cpp Outdated Show resolved Hide resolved
@Punzo @lassoan
ENH: Improve Visual DICOM browser
f507673 
PERF: Improve queue jobs performances by cleaning mutex use
ENH: Improve inserter jobs log report

Co-authored-by: Andras Lasso <lasso@queensu.ca>
@Punzo Punzo force-pushed the visualDICOMBrowserENH branch from e4e1891 to f507673 Compare September 9, 2024 21:31
@Punzo
Copy link
Contributor Author

Punzo commented Sep 9, 2024 •
edited
Loading

@lassoan thanks for the review. I have cleaned the dirty modifications to the insert methods of ctkDICOMDatabase by using an enum:

ctkDICOMDatabase::InsertResult

lassoan
lassoan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you.

@lassoan lassoan merged commit 627842c into commontk:master Sep 10, 2024
4 checks passed
@Punzo
Copy link
Contributor Author

Punzo commented Sep 10, 2024

It looks good, thank you.

thanks for reviewing and merging!

@lassoan lassoan mentioned this pull request Dec 16, 2024
Open
82 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Punzo @lassoan