-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CMake project definition improvements #25
Closed
RafaelPalomar
wants to merge
3
commits into
commontk:master
from
RafaelPalomar:feature/improve_cmake_project
Closed
CMake project definition improvements #25
RafaelPalomar
wants to merge
3
commits into
commontk:master
from
RafaelPalomar:feature/improve_cmake_project
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a refactoring of the cmake project definition taking inspiration on the vtkAddon cmake project layout. The following changes have been introduced: - Remove the use UseqRestAPI.cmake.in and derivatives. Now everything is set in the `qRestAPIConfig.cmake.in` and derivatives - Integrate the generation of configuration files (earlier in `CMake/GenerateqRestAPIConfig.cmake`) into the main `CMakeLists.txt`. - Add generation of install-tree config template file `qRestAPIInstallConfig.cmake.in` - Add installation of cmake files, header files and libraries.
RafaelPalomar
added a commit
to RafaelPalomar/Slicer
that referenced
this pull request
Jan 25, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Feb 22, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Feb 28, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 1, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 9, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 14, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 17, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 19, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 20, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 22, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Mar 23, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 13, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 18, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 20, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 21, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 23, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Apr 25, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar
added a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 23, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 25, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 27, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 28, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 29, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
github-actions bot
pushed a commit
to SystoleOS/Slicer
that referenced
this pull request
Jun 30, 2023
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this is a SystoleOS adaptation that should not reach the official Slicer repository until commontk/qRestAPI#25 gets merged.
This is superseded by #27, which is an updated version |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cmake project definition for qRestAPI:
UseqRestAPI.cmake.in
and derivatives.This PR has been greatly inspired on the project definition for vtkAddon project. The motivation for this PR is to enable this library as a standalone library that can be installed and used in other projects and will be useful to build 3D Sclier with
SUPERBUILD=OFF
and support the SystoleOS.Since these changes affect the cmake configuration files (most notably removing the need for
UseqRestAPI.cmake
file), projects using the library will need to update their cmake project definitions.