Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CMake project definition improvements #25

Closed
wants to merge 3 commits into from
Closed

CMake project definition improvements #25

wants to merge 3 commits into from

Conversation

RafaelPalomar
Copy link

@RafaelPalomar RafaelPalomar commented Dec 22, 2022 •
edited
Loading

This PR updates the cmake project definition for qRestAPI:

  • It removes the use of the deprecated Qt4.
  • It adds capabilities for installing the library and the header files (optional)
  • It simplifies the configuration generation removing the UseqRestAPI.cmake.in and derivatives.

This PR has been greatly inspired on the project definition for vtkAddon project. The motivation for this PR is to enable this library as a standalone library that can be installed and used in other projects and will be useful to build 3D Sclier with SUPERBUILD=OFF and support the SystoleOS.

Since these changes affect the cmake configuration files (most notably removing the need for UseqRestAPI.cmake file), projects using the library will need to update their cmake project definitions.

@RafaelPalomar
ENH: Update cmake requirements
ec1f731
@RafaelPalomar
ENH: Remove the use of Qt4
905fd3f
@RafaelPalomar
ENH: Refactor CMake project definition
8ca2786 
This does a refactoring of the cmake project definition taking
inspiration on the vtkAddon cmake project layout. The following changes
have been introduced:

  - Remove the use UseqRestAPI.cmake.in and derivatives. Now everything is set in the `qRestAPIConfig.cmake.in` and derivatives
  - Integrate the generation of configuration files (earlier in `CMake/GenerateqRestAPIConfig.cmake`) into the main `CMakeLists.txt`.
  - Add generation of install-tree config template file `qRestAPIInstallConfig.cmake.in`
  - Add installation of cmake files, header files and libraries.
RafaelPalomar added a commit to RafaelPalomar/Slicer that referenced this pull request Jan 25, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
cb2a016 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Feb 22, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
8768fb2 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Feb 28, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
6e918dd 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 1, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
05c1c2e 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 9, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
3ccd088 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 14, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
a972976 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Mar 17, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
06b6813 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Mar 19, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
90f3244 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Mar 20, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
14c20a1 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Mar 22, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
9f8b973 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Mar 23, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
72c162a 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Apr 13, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
b9c72fb 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 18, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
7757e38 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 20, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
d7ff246 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 21, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
8c1967f 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 23, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
6ca2452 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Apr 25, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
aacb7da 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
RafaelPalomar added a commit to SystoleOS/Slicer that referenced this pull request Jun 23, 2023
@RafaelPalomar
COMP: Adapt to new qRestAPI cmake
bad1b88 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 25, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
31671c6 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 27, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
66a8c3d 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 28, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
dee37c8 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 29, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
df1bc27 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
github-actions bot pushed a commit to SystoleOS/Slicer that referenced this pull request Jun 30, 2023
@RafaelPalomar @github-actions
COMP: Adapt to new qRestAPI cmake
8a002d2 
This removes the use of the old `qRestAPI_USE_FILE`. As of today, this
is a SystoleOS adaptation that should not reach the official Slicer
repository until commontk/qRestAPI#25 gets merged.
@RafaelPalomar RafaelPalomar closed this by deleting the head repository Jan 13, 2024
@RafaelPalomar
Copy link
Author

This is superseded by #27, which is an updated version

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RafaelPalomar