Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[API] Update build.func / Improve error messages #2 #2050

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

michelroegl-brunner
Copy link
Member

✍️ Description

This PR updates build.func to better handle error messages to the API.



✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner February 5, 2025 13:07
@github-actions github-actions bot added maintenance Code maintenance or general upkeep of the project high risk A change that can affect many scripts labels Feb 5, 2025
@github-actions github-actions bot added the update script A change that updates a script label Feb 5, 2025
Copy link
Contributor

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and did even learn a new command trap, jut looked it up, and theoretically looks fine to me :)

@michelroegl-brunner michelroegl-brunner merged commit 6826747 into main Feb 5, 2025
1 check passed
@michelroegl-brunner michelroegl-brunner deleted the api_update_buildfunc branch February 7, 2025 15:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants