fix: empty user defined hint is used #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can I ask for a simple test for this behaviour? I assume you already have something, you can just copy-paste that. |
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
|
added a test case to cover it |
xukai92
added a commit
to xukai92/Comonicon.jl
that referenced
this pull request
Sep 5, 2023
Roger-luo
pushed a commit
that referenced
this pull request
Sep 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user hint is used even when it is empty.
falling back to the default hint now with this PR