Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support weakdeps #252

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Support weakdeps #252

merged 4 commits into from
Sep 11, 2023

Conversation

qiaojunfeng
Copy link
Contributor

Hi, thanks for sharing the package!

Julia 1.9 introduces package extension, it seems Comonicon does not support this yet?

I just tried to come up with a quick hack, and it seems working fine in my case. Would be great if someone could have a look at this PR (maybe use this as a hint), and properly support this Julia feature in Comonicon. Thanks!

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage is 75.00% of modified lines.

Files Changed Coverage
src/builder/sysimg.jl 75.00%

📢 Thoughts on this report? Let us know!.

@Roger-luo
Copy link
Collaborator

Ah right, thanks!

The building procedure uses a hack to create a build env based on your test and project env. Can you add a test project test to check if this works in the test suite? You can add a weakdeps in this example project https://github.com/comonicon/Comonicon.jl/tree/main/example/FakePkg

and you can modify the tests in that package.

@qiaojunfeng
Copy link
Contributor Author

Thanks!
Changed a bit the Project.toml of FakePkg to test the PR, I think we don't need to add other test files since without this PR the FakePkg.comonicon_install() would fail in the current tests of FakePkg/test/runtests.jl.

@qiaojunfeng
Copy link
Contributor Author

Ok, pushed another commit, this should fix the Julia 1.6 tests

@qiaojunfeng
Copy link
Contributor Author

Ok pushed a fix for Julia 1.6 again, could you restart the CI? Thanks!

@qiaojunfeng
Copy link
Contributor Author

I think the code is fine now, but it seems the coverage of example wasn't generated so the coverage tests didn't pass

[ Info: CoverageTools.process_file: Detecting coverage for src/builder/sysimg.jl
┌ Info: CoverageTools.process_cov: Coverage file(s) for src/builder/sysimg.jl do not exist.
└ Assuming file has no coverage.

from the Run julia-actions/julia-processcoverage@v1 step of https://github.com/comonicon/Comonicon.jl/actions/runs/6111989250/job/16591892397

@Roger-luo
Copy link
Collaborator

Thanks fine it's not much, thanks!

@Roger-luo Roger-luo merged commit afd7e15 into comonicon:main Sep 11, 2023
@qiaojunfeng qiaojunfeng deleted the weakdeps branch September 11, 2023 15:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants