-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ability to compile CppInterOp and tests on Windows with different compiler #195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 8 8
Lines 3048 3048
=======================================
Hits 2403 2403
Misses 645 645
|
clang-tidy review says "All clean, LGTM! 👍" |
Can we use |
@vgvassilev So just to be certain before I make the change, you want me to reactivate the other Windows builds, but add continue-on-error: true to the 'Build and Test/Install CppInterOp on Windows systems' part of the jobs? |
Yes, assuming we still get some green/ or different than X build sign. |
clang-tidy review says "All clean, LGTM! 👍" |
@vgvassilev After that change the Windows builds now get a green tick. I have added a comment to this section that tests are expected to fail until #188 is resolved. |
@vgvassilev Can this PR be merged now that is gets a green tick for all the jobs? |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
@alexander-penev can you review this PR for me? The purpose of the PR is to do 3 things
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@vgvassilev This PR allows for those trying to solve Windows build issues to use a different compiler to MSVC . With these changes I was able to compile CppInterOp and its tests using the Clang compiler. Currently I'm not passing the tests as the header files cannot be found, but I believe this has something to do with the environment variables I have set, and am investigating.
Fixes #175 (provides proof that earlier PR fixed it)