Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make running emscripten_wasm dependent on sucessfull run of build in ci #223

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Apr 8, 2024

This PR makes running emscripten_wasm dependent on sucessfull run of build in ci. This should reduce ci resources being used uncessarily, to be used by other PRs in the organisation.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Apr 8, 2024

@vgvassilev This is a minor change to the way the ci works to help alleviate some of the issues which occur when multiple PRs are put in. It stops the wasm build being check unless the non warm build passes sucessfully.

I'm hoping to put in more PRs over the coming week to help in other ways as I have time.

@vgvassilev
Copy link
Contributor

That probably lifts the cache issue and replaces it with longer build times. I think it is probably fine. FWIW, your CI magic becomes quite advanced and I am not sure if I can review it ;) but it looks good to me.

@maximusron what do you think?

@aaronj0
Copy link
Collaborator

aaronj0 commented Apr 9, 2024

@mcbarton @vgvassilev this looks good and should help. I think we can eventually figure out similar conditional additions that can run less builds that are expected to fail, if things that precede the dependecy chain don't build. This way we can aim for a more ideal build chain, and combined with reusing the cache, should optimise the CI overall

@vgvassilev vgvassilev merged commit e9ada81 into compiler-research:main Apr 9, 2024
40 checks passed
@mcbarton mcbarton deleted the ci-build-dependency branch April 9, 2024 17:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants