Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce cache size #229

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

mcbarton
Copy link
Collaborator

@vgvassilev can you clear the cache, and then manually rerun the workflow of this PR? It should pass, while having a reduced llvm cache, based on the workflow in xeus-clang-repl.

@vgvassilev
Copy link
Contributor

Why are we still building a cache for clang-18? Should we not get it via the package manager?

@mcbarton
Copy link
Collaborator Author

Why are we still building a cache for clang-18? Should we not get it via the package manager?

We can get rid of it via a package manager, but not for all systems yet (osx Homebrew doesn't currently have llvm 18, but its in progress). Its also not available through Emscripten forge yet for the web assembley. I think we'll be able to remove the llvm 18 cache, but not for a few weeks. This PR should significantly reduce the size of the cache if it works. The cache will also be reduce even more when I put in my PR which removes the osx x86 jobs.

@mcbarton
Copy link
Collaborator Author

@vgvassilev I won't be able to be certain this PR works until the cache is cleared and the workflow is run manually.

@vgvassilev
Copy link
Contributor

Yes, just waiting for a job to finish and I will merge it.

@mcbarton
Copy link
Collaborator Author

Yes, just waiting for a job to finish and I will merge it.

I wouldn't merge this one yet until its been able to be tested. I'm not 100 % sure this PR works.

@vgvassilev
Copy link
Contributor

Yes, just waiting for a job to finish and I will merge it.

I wouldn't merge this one yet until its been able to be tested. I'm not 100 % sure this PR works.

I reran with the cache cleared and indeed you are right we might need to improve this PR.

@mcbarton
Copy link
Collaborator Author

@vgvassilev can you clear the cache and rerun this PR?

@vgvassilev
Copy link
Contributor

Done.

@mcbarton mcbarton force-pushed the reduce-cache-size branch from 06eb1ed to b598dbb Compare April 21, 2024 10:00
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (e639070) to head (b598dbb).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   77.75%   79.25%   +1.50%     
==========================================
  Files           8        8              
  Lines        2949     3100     +151     
==========================================
+ Hits         2293     2457     +164     
+ Misses        656      643      -13     

see 8 files with indirect coverage changes

see 8 files with indirect coverage changes

@mcbarton
Copy link
Collaborator Author

@vgvassilev This PR is ready for merging. I recommend clearing the cache before merging.

@vgvassilev vgvassilev merged commit 6ee85f6 into compiler-research:main Apr 21, 2024
42 checks passed
@mcbarton mcbarton deleted the reduce-cache-size branch May 22, 2024 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants