Skip to content

Reduce windows cache size + add options needed for wasm build of CppInterOp on Windows to llvm cache #249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

@vgvassilev This PR contains 2 commits. One should reduce the size of the llvm cache on Windows. The second changes the options when building llvm on Windows to allow a wasm build of CppInterOp on Windows to be added to the ci in a future PR. To test this PR you will need to clear the Windows builds in the cache, and rerun in workflow manually.

@vgvassilev
Copy link
Contributor

@vgvassilev This PR contains 2 commits. One should reduce the size of the llvm cache on Windows. The second changes the options when building llvm on Windows to allow a wasm build of CppInterOp on Windows to be added to the ci in a future PR. To test this PR you will need to clear the Windows builds in the cache, and rerun in workflow manually.

@mcbarton, done, let's see...

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (f93e7b6) to head (3bac975).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   87.65%   79.37%   -8.29%     
==========================================
  Files           4        8       +4     
  Lines        1742     2982    +1240     
==========================================
+ Hits         1527     2367     +840     
- Misses        215      615     +400     

see 8 files with indirect coverage changes

see 8 files with indirect coverage changes

@mcbarton
Copy link
Collaborator Author

mcbarton commented Apr 30, 2024

@vgvassilev This PR works as intended so can be merged now. I recommend you clear the cache before merging, when no other workflows are running. @alexander-penev @maximusron I also recommend you put in no new PRs, or commits to current PRs until the cache has been rebuilt after merging. This is to stop these PRs making there own cache, which will overwhelm the cache size limit.

@vgvassilev vgvassilev merged commit 2770618 into compiler-research:main May 1, 2024
28 of 35 checks passed
@mcbarton mcbarton deleted the reduce-Windows-cache-size branch May 22, 2024 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants