Skip to content

Fix warning micromamba envirnoment setup ci #282

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

mcbarton
Copy link
Collaborator

This PR is part of the node 16 to node 20 transition. It should stop the warning appearing when the ci runs due to the provision-with-micromamba action.

@mcbarton mcbarton force-pushed the fix-micromamba-warning-ci branch from 8e15df8 to 0ced924 Compare May 14, 2024 15:21
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (f93e7b6) to head (df10fc0).
Report is 30 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #282       +/-   ##
===========================================
- Coverage   87.65%   54.31%   -33.35%     
===========================================
  Files           4        8        +4     
  Lines        1742     2957     +1215     
===========================================
+ Hits         1527     1606       +79     
- Misses        215     1351     +1136     

see 8 files with indirect coverage changes

see 8 files with indirect coverage changes

@mcbarton mcbarton force-pushed the fix-micromamba-warning-ci branch from 0ced924 to df10fc0 Compare May 15, 2024 16:16
@mcbarton
Copy link
Collaborator Author

@vgvassilev can this PR be merged? It is part of the node 16 to node 20 transition. After this is merged only the Windows errors will need to be dealth with when the ci runs to have no errors or warnings.

@vgvassilev vgvassilev requested a review from aaronj0 May 15, 2024 16:22
@aaronj0
Copy link
Collaborator

aaronj0 commented May 15, 2024

this looks good, but the codecov has dropped very drastically.. we should investigate this...

I tried looking into codecov reports with miromamba and couldn't find much. however. I did notice that both this and the other PR have dropped the codecoverage by the same number, see https://app.codecov.io/gh/compiler-research/CppInterOp/pulls

@mcbarton
Copy link
Collaborator Author

this looks good, but the codecov has dropped very drastically.. we should investigate this...

I tried looking into codecov reports with miromamba and couldn't find much. however. I did notice that both this and the other PR have dropped the codecoverage by the same number, see https://app.codecov.io/gh/compiler-research/CppInterOp/pulls

@maximusron The drop in codecov drop has nothing to do with this PR. It dropped when we stopped having coverage turned to true in all Ubuntu jobs. The coverage number on the main branch is not updating from the 88%, after that PR merge seems to be the issue.

@mcbarton
Copy link
Collaborator Author

@vgvassilev The issue with the coverage number not updating on the main is due to the token issue just like in xeus-cpp. Can you fix it like you did xeus-cpp repo?
Error message can be seen on the nightly runs of the ci on main.
Error: Codecov token not found. Please provide Codecov token with -t flag.

@mcbarton
Copy link
Collaborator Author

@maximusron can you merge this now that I have outlined the issue with the coverage in an issue? It has nothing to do with this PR, but a new condition on coverage report uploading and tokens.

@aaronj0 aaronj0 merged commit 791995a into compiler-research:main May 15, 2024
45 of 46 checks passed
@mcbarton mcbarton deleted the fix-micromamba-warning-ci branch May 22, 2024 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants