-
Notifications
You must be signed in to change notification settings - Fork 31
Fix warning micromamba envirnoment setup ci #282
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix warning micromamba envirnoment setup ci #282
Conversation
8e15df8
to
0ced924
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
===========================================
- Coverage 87.65% 54.31% -33.35%
===========================================
Files 4 8 +4
Lines 1742 2957 +1215
===========================================
+ Hits 1527 1606 +79
- Misses 215 1351 +1136 |
0ced924
to
df10fc0
Compare
@vgvassilev can this PR be merged? It is part of the node 16 to node 20 transition. After this is merged only the Windows errors will need to be dealth with when the ci runs to have no errors or warnings. |
this looks good, but the codecov has dropped very drastically.. we should investigate this... I tried looking into codecov reports with miromamba and couldn't find much. however. I did notice that both this and the other PR have dropped the codecoverage by the same number, see https://app.codecov.io/gh/compiler-research/CppInterOp/pulls |
@maximusron The drop in codecov drop has nothing to do with this PR. It dropped when we stopped having coverage turned to true in all Ubuntu jobs. The coverage number on the main branch is not updating from the 88%, after that PR merge seems to be the issue. |
@vgvassilev The issue with the coverage number not updating on the main is due to the token issue just like in xeus-cpp. Can you fix it like you did xeus-cpp repo? |
@maximusron can you merge this now that I have outlined the issue with the coverage in an issue? It has nothing to do with this PR, but a new condition on coverage report uploading and tokens. |
This PR is part of the node 16 to node 20 transition. It should stop the warning appearing when the ci runs due to the provision-with-micromamba action.