Skip to content

Fix bug due to swiftlint osx jobs ci #291

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 18, 2024

Conversation

mcbarton
Copy link
Collaborator

@vgvassilev @maximusron can one of you merge this into the main to fix the issue with osx x86 jobs? I know this fix works as I'm currently using it in my PR on treating all warnings as errors.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 18, 2024

@mcbarton will do once the checks are done

@aaronj0
Copy link
Collaborator

aaronj0 commented May 18, 2024

@mcbarton we need the cache from PR #281 since LLVM has to be built after valgrind. I will rerun these jobs to avoid both of them building a cache at the same time

@mcbarton
Copy link
Collaborator Author

@maximusron The cache from both PRs can't clash since there isn't a Ubuntu cache on the main anymore. One PR cannot pickup the cache from another PR. This PR also has nothing to do with caching. It is just removing a package which causes issues on osx. Unsure why the ci run had to be cancelled.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 18, 2024

Yes, I cleared the main cache for the same reason I mentioned above. That's why I would prefer that this PR doesn't also build a cache at the same time. Once the new cache is built, this PR can just use that and make things more simple (instead of having to clear this cache too once this is done).

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (114b3ff) to head (1e928f8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   54.31%   54.31%           
=======================================
  Files           8        8           
  Lines        2957     2957           
=======================================
  Hits         1606     1606           
  Misses       1351     1351           

@aaronj0 aaronj0 self-requested a review May 18, 2024 13:30
@aaronj0 aaronj0 merged commit f20c606 into compiler-research:main May 18, 2024
46 of 48 checks passed
@mcbarton mcbarton deleted the fix-osx-x86-jobs branch May 22, 2024 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants