Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix unit test failure #297

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix unit test failure #297

merged 1 commit into from
May 20, 2024

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented May 20, 2024

No description provided.

@aaronj0 aaronj0 changed the title Fix unittest failure Fix unit test failure May 20, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (ecb1b33) to head (a764da1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   72.20%   72.22%   +0.01%     
==========================================
  Files           8        8              
  Lines        2961     2963       +2     
==========================================
+ Hits         2138     2140       +2     
  Misses        823      823              
Files Coverage Δ
lib/Interpreter/CppInterOp.cpp 78.52% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
lib/Interpreter/CppInterOp.cpp 78.52% <100.00%> (+0.02%) ⬆️

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@aaronj0
Copy link
Collaborator Author

aaronj0 commented May 20, 2024

Merging, as this fixes the non wasm builds on the CI

@aaronj0 aaronj0 merged commit c8979a2 into main May 20, 2024
36 of 48 checks passed
@vgvassilev vgvassilev deleted the unittest-fix branch May 20, 2024 09:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant