-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support recent cling. #318
Support recent cling. #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
rerunning jobs, since the first stage in the CI matrix did not run the InterOp build + unittests and a windows job was cancelled preventing the rest of the CI from running |
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 8 8
Lines 2979 2979
=======================================
Hits 2186 2186
Misses 793 793
|
@vgvassilev looks like this is ready to be merged.. |
2580333
to
ed84822
Compare
clang-tidy review says "All clean, LGTM! 👍" |
No description provided.