-
Notifications
You must be signed in to change notification settings - Fork 31
fixes some variables in CppInterOpconfig.cmake.in file #336
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gentle ping. I think this should be ready. Pretty small change. Can be seen while building xeus-cpp that cmake dir is not set correctly. This PR fixes that
|
vgvassilev
reviewed
Nov 22, 2024
As you have approved compiler-research/xeus-cpp#166 |
f1b46ce
to
1912e99
Compare
alexander-penev
approved these changes
Dec 5, 2024
alexander-penev
approved these changes
Dec 6, 2024
Hey @vgvassilev This should be ready now ! |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered while building xeus-cpp . We have the following in xeus-cpp
which ends up being
So
CPPINTEROP_CONFIG
,CPPINTEROP_DIR
,CPPINTEROP_VERSION
are empty butCPPINTEROP_LLVM_VERSION_MAJOR
has"19.x"
After this we could have