Skip to content

fixes some variables in CppInterOpconfig.cmake.in file #336

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

anutosh491
Copy link
Collaborator

This was discovered while building xeus-cpp . We have the following in xeus-cpp

find_package(CppInterOp ${CppInterOp_REQUIRED_VERSION} REQUIRED)
if(CppInterOp_FOUND)
  message(STATUS "Found CppInterOp: config=${CPPINTEROP_CONFIG} dir=${CPPINTEROP_DIR} (found version=${CPPINTEROP_VERSION} compatible with Clang ${CPPINTEROP_LLVM_VERSION_MAJOR}.x)")
endif()

which ends up being

Found CppInterOp: config= dir= (found version= compatible with Clang 19.x)

So CPPINTEROP_CONFIG , CPPINTEROP_DIR, CPPINTEROP_VERSION are empty but CPPINTEROP_LLVM_VERSION_MAJOR has "19.x"

After this we could have

message(STATUS "Found CppInterOp: config=${CPPINTEROP_CMAKE_DIR} dir=${CPPINTEROP_INSTALL_PREFIX} (found version=${CPPINTEROP_LLVM_PACKAGE_VERSION} compatible with Clang ${CPPINTEROP_LLVM_VERSION_MAJOR}.x)")

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (b90a9db) to head (28af4b4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files           8        8           
  Lines        3137     3137           
=======================================
  Hits         2389     2389           
  Misses        748      748           

@anutosh491
Copy link
Collaborator Author

Gentle ping. I think this should be ready. Pretty small change. Can be seen while building xeus-cpp that cmake dir is not set correctly. This PR fixes that

-- Found compatible xeus version: 5.1.1
-- CPPINTEROP_CONFIG: /Users/anutosh491/micromamba/envs/xeus-cpp/lib/cmake/cppinterop
-- CPPINTEROP_CMAKE_DIR: 
-- CPPINTEROP_LIBRARIES: /Users/anutosh491/micromamba/envs/xeus-cpp/lib/libclangCppInterOp.dylib
-- CPPINTEROP_DIR: /Users/anutosh491/micromamba/envs/xeus-cpp
-- CPPINTEROP_VERSION: 1.4.0

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Dec 4, 2024

As you have approved compiler-research/xeus-cpp#166
I would be glad if you could check this out too (especially the discussion with Vassil above)

@alexander-penev

@anutosh491 anutosh491 force-pushed the cmake branch 2 times, most recently from f1b46ce to 1912e99 Compare December 5, 2024 06:29
@anutosh491
Copy link
Collaborator Author

Hey @vgvassilev

This should be ready now !

@mcbarton mcbarton merged commit 1c3f884 into compiler-research:main Dec 6, 2024
40 checks passed
@anutosh491 anutosh491 deleted the cmake branch December 6, 2024 12:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants