-
Notifications
You must be signed in to change notification settings - Fork 31
Remove ci warnings about linking of openssl brew #339
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove ci warnings about linking of openssl brew #339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 74.43% 74.57% +0.14%
==========================================
Files 8 8
Lines 3204 3214 +10
==========================================
+ Hits 2385 2397 +12
+ Misses 819 817 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge when the bots are happy.
fbabdba
to
0969ff6
Compare
@vgvassilev I eventually found a solution to stop the warning about linking openssl when upgrading, but its kind of a fudge. I just redirect the standard output and error when upgrading openssl, so that the Github ci doesn't detect the warning. Is this solution ok to merge? |
Yeah, we do what we can ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently we have a warning in the ci about files being overwritten during the brew link stage for openssl. By removing openssl we should stop this warning appearing when the ci runs.