Skip to content

Remove ci warnings about linking of openssl brew #339

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

mcbarton
Copy link
Collaborator

Currently we have a warning in the ci about files being overwritten during the brew link stage for openssl. By removing openssl we should stop this warning appearing when the ci runs.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (29588be) to head (143a494).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   74.43%   74.57%   +0.14%     
==========================================
  Files           8        8              
  Lines        3204     3214      +10     
==========================================
+ Hits         2385     2397      +12     
+ Misses        819      817       -2     

see 3 files with indirect coverage changes

see 3 files with indirect coverage changes

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge when the bots are happy.

@mcbarton mcbarton changed the title Remove openssl@3 ci brew Remove ci warnings about linking of openssl brew Oct 28, 2024
@mcbarton mcbarton force-pushed the link-warning-ci-removal branch from fbabdba to 0969ff6 Compare October 30, 2024 14:46
@mcbarton mcbarton marked this pull request as draft October 30, 2024 20:58
@mcbarton mcbarton requested a review from vgvassilev November 27, 2024 19:21
@mcbarton mcbarton marked this pull request as ready for review November 27, 2024 19:21
@mcbarton
Copy link
Collaborator Author

@vgvassilev I eventually found a solution to stop the warning about linking openssl when upgrading, but its kind of a fudge. I just redirect the standard output and error when upgrading openssl, so that the Github ci doesn't detect the warning. Is this solution ok to merge?

@vgvassilev
Copy link
Contributor

@vgvassilev I eventually found a solution to stop the warning about linking openssl when upgrading, but its kind of a fudge. I just redirect the standard output and error when upgrading openssl, so that the Github ci doesn't detect the warning. Is this solution ok to merge?

Yeah, we do what we can ;)

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton merged commit 5f1d956 into compiler-research:main Nov 27, 2024
53 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants