Replace std::regex in codecomplete to use llvm::regex #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jan 9, 2025
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jan 9, 2025
| // remove <# #> to keep only the type | ||
| r = std::regex_replace(r, std::regex("\\<\\#([^#>]*)\\#\\>"), "$1"); | ||
| r = removeTags.sub("$1", r, &error); | ||
|
|
There was a problem hiding this comment.
Can we check the error variable and fail if there is something in it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 9 9
Lines 3541 3541
=======================================
Hits 2513 2513
Misses 1028 1028
|
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jan 16, 2025
lib/Interpreter/Compatibility.h
Outdated
| @@ -163,17 +166,45 @@ inline void codeComplete(std::vector<std::string>& Results, | |||
| std::vector<std::string> results; | |||
| size_t column = complete_column; | |||
| I.codeComplete(code, column, results); | |||
| std::string error; | |||
| llvm::Error Err; | |||
There was a problem hiding this comment.
Suggested change
| llvm::Error Err; | |
| llvm::Error Err = llvm::Error::success(); |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexander-penev We ran into an issue with torchlib that is triggered by the loading of
std::regex. I have replaced the usage withllvm::Regexthat fi xes it. Can you verify if this works with your usecases when developing the feature? The unittests for codecomplete pass but I am not sure if it is extensive enough..