normalize copy plugin. Fixes #166 #167
Conversation
| function normalize(conf, list){ | ||
| return conf == list[0] | ||
| ? conf.name | ||
| : require('path').basename(conf.path()); |
There was a problem hiding this comment.
this looks weird; why not just use basename defined at L14?
There was a problem hiding this comment.
Not sure why I did that. Removed L14.
There was a problem hiding this comment.
would be good to not require() inside a function, since it's sync ?
There was a problem hiding this comment.
@yields shouldn't matter, as path has been required multiple times areadly in this file
There was a problem hiding this comment.
oh yeah, i know require()'s are cached :) just looks weird IMHO haha
There was a problem hiding this comment.
yeah looks very weird i agree
There was a problem hiding this comment.
Okay I’ve moved it.
--
Aaron Zhang
On March 10, 2014 at 3:28:49 PM, Stephen Mathieson (notifications@github.com) wrote:
In lib/plugins/copy.js:
@@ -62,3 +63,19 @@ module.exports = function(type, dest, opts){
batch.end(done);
};
};
+
+
+/**
—
Reply to this email directly or view it on GitHub.
moved require('path').basename outside of the function
No description provided.