Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

add goja as JS VM for transformers #294

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Conversation

jipperinbham
Copy link
Contributor

@jipperinbham jipperinbham commented Mar 7, 2017

goja looks to be a nice alternative to offer people who may need a little more performance from the transformer function. Initial benchmarks showed the following results:

$ benchcmp otto.profile gojajs/gojajs.profile
benchmark                   old ns/op     new ns/op     delta
BenchmarkTransformOne-8     13565         6265          -53.81%
  • CHANGELOG.md updated
  • README.md updated

fixes #230

@codecov
Copy link

codecov bot commented Mar 7, 2017

Codecov Report

Merging #294 into master will decrease coverage by 0.09%.
The diff coverage is 88%.

@@            Coverage Diff            @@
##           master     #294     +/-   ##
=========================================
- Coverage   80.84%   80.74%   -0.1%     
=========================================
  Files          46       48      +2     
  Lines        2490     2587     +97     
=========================================
+ Hits         2013     2089     +76     
- Misses        335      350     +15     
- Partials      142      148      +6
Impacted Files Coverage Δ
adaptor/transformer/ottojs/client.go 45.71% <ø> (ø)
adaptor/transformer/ottojs/writer.go 68.81% <ø> (ø)
adaptor/transformer/transformer.go 100% <100%> (ø)
adaptor/transformer/gojajs/client.go 82.35% <82.35%> (ø)
adaptor/transformer/gojajs/writer.go 89.65% <89.65%> (ø)
state/filestore.go 49.05% <0%> (-3.78%)
adaptor/postgres/tailer.go 78.97% <0%> (-1.14%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1329019...ab7a38f. Read the comment docs.

transformer adaptor can now be configured to use the goja VM with the transformer function

fixes #230
@jipperinbham jipperinbham merged commit 13309f2 into master Mar 10, 2017
@jipperinbham jipperinbham deleted the 230-js-vm-throwdown branch March 10, 2017 20:59
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate JS VMs
1 participant